Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turned on directory layout tests for emmo and made them pytest #706

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Turned on directory layout tests for emmo and made them pytest #706

merged 2 commits into from
Jan 24, 2024

Conversation

francescalb
Copy link
Collaborator

Description

The test did not run by default.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ffe31b) 71.27% compared to head (11e6a64) 71.24%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
- Coverage   71.27%   71.24%   -0.03%     
==========================================
  Files          16       16              
  Lines        3405     3405              
==========================================
- Hits         2427     2426       -1     
- Misses        978      979       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescalb francescalb changed the title Turned on directory layout test for emmo and made them pytet Turned on directory layout test for emmo and made them pytest Jan 24, 2024
@francescalb francescalb changed the title Turned on directory layout test for emmo and made them pytest Turned on directory layout tests for emmo and made them pytest Jan 24, 2024
@jesper-friis jesper-friis self-requested a review January 24, 2024 15:58
@francescalb @jesper-friis
Update tests/test_utils_directory_layout.py
11e6a64 
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
@francescalb francescalb merged commit e0f315e into master Jan 24, 2024
11 of 12 checks passed
@francescalb francescalb deleted the turn_on_directory_layout_test_emmo branch January 24, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesper-friis jesper-friis jesper-friis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francescalb @jesper-friis